feat: allow any authentication provider + fief OIDC #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
do we need multiple auth providers ? |
Collaborator
Author
Thanks for the comment @prmths128 ! I agree we won't need 2 auth providers ever at the same time. On the other hand if we can implement the fastapi_oidc so that the server is injected and easily plugable? Like that for local dev we inject a mock and it is easier to work with it. What do you think? |
inimaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using directly Fief, we can pass an auth_provider interface that uses OIDC and points to Fief.
Two main gains:
auth_providerinterface.carbonserver/carbonserver/api/services/auth_providers/no_auth_provider.py, for testing purposes. This will allow the UI in local to be easier to test/develop.Related to #861